datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Stop copying LogicalPlan and Exprs in `RewriteDisjunctivePredicate`

Open alamb opened this issue 1 year ago • 2 comments

Is your feature request related to a problem or challenge?

As part of making the planner faster, we are updating the passes to avoid copying LogicalPlan and Expr (see https://github.com/apache/datafusion/issues/9637)

Describe the solution you'd like

I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)

Describe alternatives you've considered

Apply the model from @Lordworms in https://github.com/apache/datafusion/pull/10166 to RewriteDisjunctivePredicate .

Additional context

I think this will be a pretty simple refactor with a good existing pattern, so mark this as good first issue

alamb avatar Apr 24 '24 11:04 alamb

I'll take this one.

rohitrastogi avatar Apr 25 '24 21:04 rohitrastogi

Thanks @rohitrastogi 🙏

alamb avatar Apr 25 '24 22:04 alamb