datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Array agg groups accumulator

Open lkt opened this issue 1 year ago • 4 comments

Which issue does this PR close?

Closes #10145.

Rationale for this change

See the issue.

What changes are included in this PR?

GroupsAccumulator for array_agg aggregation function for:

  • Primitive types
  • String type

Not included:

  • Accumulating arrays of any level of nesting.

Are these changes tested?

Extended tests in array_agg.rs

Are there any user-facing changes?

No, just a performance improvement.

lkt avatar Apr 20 '24 08:04 lkt

Thank you for this PR @lkt -- I will take a look at this one carefully shortly

alamb avatar Apr 22 '24 20:04 alamb

Thanks @lkt for your contribution, does this PR stand for array_agg performance improvement? If so it is good to see a bench mark results

comphead avatar Apr 24 '24 15:04 comphead

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 25 '24 01:06 github-actions[bot]

Seems to be superceded by https://github.com/apache/datafusion/pull/11096

alamb avatar Jun 28 '24 21:06 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 31 '24 01:08 github-actions[bot]