datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Deprecate builtin first/last aggregate function and use UDAF

Open jayzhan211 opened this issue 1 year ago • 2 comments

Which issue does this PR close?

Part of #8708 Closes #9957 #10062

Rationale for this change

What changes are included in this PR?

Additionally, check the signature for UDAF, and extend it to support List. Window Aggregate function also works with UDAF surprisingly without any change about the window function

Are these changes tested?

Are there any user-facing changes?

jayzhan211 avatar Apr 15 '24 23:04 jayzhan211

I plan to review this tomorrow (sorry I am out this week for vacation so I have more limited bandwidth)

alamb avatar Apr 17 '24 17:04 alamb

I think reverse_expr should be included before deprecate builtint first/last, so convert to draft.

jayzhan211 avatar Apr 20 '24 07:04 jayzhan211