datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard
verified publisher icon apache

SumDecimal always returns nullable=true

Open andygrove opened this issue 1 year ago • 1 comments

Describe the bug

SumDecimal currently hardcodes nullable=true, and this is correct when ANSI mode is not enabled, because overflows cause null values. However, in ANSI mode, overflows cause exceptions. If the input is non-nullable then SumDecimal should probably also be non-nullable. The same is true for AvgDecimal.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

andygrove avatar Sep 24 '24 14:09 andygrove

I will be working on this.

vaibhawvipul avatar Sep 30 '24 05:09 vaibhawvipul