datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

Add ANSI support for Remainder

Open andygrove opened this issue 1 year ago • 1 comments

What is the problem the feature request solves?

Spark has specific handling of overflows when ANSI mode is enabled and we need to add the same in Comet.

Describe the potential solution

No response

Additional context

No response

andygrove avatar Jun 06 '24 15:06 andygrove

I am working on this.

vaibhawvipul avatar Jun 21 '24 17:06 vaibhawvipul

Hello @vaibhawvipul are you still working on it? Can I take this?

rishvin avatar Jun 21 '25 02:06 rishvin

Hello @vaibhawvipul are you still working on it? Can I take this?

no feel free to take this up

vaibhawvipul avatar Jun 21 '25 03:06 vaibhawvipul

take

rishvin avatar Jun 21 '25 04:06 rishvin

Opened PR: https://github.com/apache/datafusion-comet/pull/1971

rishvin avatar Jul 01 '25 18:07 rishvin