datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

Add tests for casting between timestamp types

Open andygrove opened this issue 1 year ago • 1 comments

What is the problem the feature request solves?

We currently delegate to DataFusion when casting between timestamps (as discovered in https://github.com/apache/datafusion-comet/pull/461) but I am not convinced that we have comprehensive tests to ensure that this is compatible with Spark.

This issue is for adding specific tests for casting between timestamp types.

Describe the potential solution

No response

Additional context

No response

andygrove avatar May 23 '24 23:05 andygrove

In CometExpressionSuite we have - test("cast timestamp and timestamp_ntz") (long -> timestamp/timestamp_ntz) test("cast timestamp and timestamp_ntz to string") test("cast timestamp and timestamp_ntz to long, date")

Do we want to add more values in these tests or do we want some more combinations tested (which ones)?

parthchandra avatar May 29 '24 19:05 parthchandra