datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

[EPIC] Fully support ANSI mode

Open andygrove opened this issue 1 year ago • 5 comments

What is the problem the feature request solves?

This epic is to track the work required to fully support ANSI mode in Comet.

Here are some known areas where we need to add ANSI support. This list will grow as we investigate more.

Features that Comet currently implements

  • Math
    • Abs https://github.com/apache/datafusion-comet/issues/464
    • UnaryMinus https://github.com/apache/datafusion-comet/issues/465
    • Round/BRound https://github.com/apache/datafusion-comet/issues/466
    • BinaryArithmetic
      • Add https://github.com/apache/datafusion-comet/issues/536
      • Subtract https://github.com/apache/datafusion-comet/issues/535
      • Multiply https://github.com/apache/datafusion-comet/issues/534
      • Divide & IntegralDivide https://github.com/apache/datafusion-comet/issues/533
      • Remainder https://github.com/apache/datafusion-comet/issues/532
  • Aggregate expression overflow
    • https://github.com/apache/datafusion-comet/issues/531
  • Other
    • Cast (covered in https://github.com/apache/datafusion-comet/issues/286)
    • https://github.com/apache/datafusion-comet/issues/2215

Features that Comet has not implemented yet

  • Math
    • Pmod
  • Date/time
    • UnixTimestamp
    • ToUnixTimestamp
    • GetTimestamp
    • ToTimestamp
    • DateAdd
    • NextDay
    • MakeDate
    • MakeTimestamp
    • DivideInterval
    • MultiplyInterval
    • MakeInterval

Describe the potential solution

No response

Additional context

No response

andygrove avatar Apr 24 '24 13:04 andygrove

@andygrove I'm reaching out to inquire about the current priority of this issue and to express my interest in contributing to this issue. It seems like a valuable addition to the project.

dharanad avatar Jul 21 '24 20:07 dharanad

Hi @dharanad. All of the issues here are important for Spark 4.0 support. Feel free to pick up any issues that are not already being worked on

andygrove avatar Aug 13 '24 19:08 andygrove