datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

feat: [CometFuzz] Add support for literal arguments [WIP]

Open andygrove opened this issue 2 months ago • 2 comments

Which issue does this PR close?

Part of https://github.com/apache/datafusion-comet/issues/2628

Rationale for this change

Increase test coverage by picking both columns and literals for arguments to scalar functions.

SELECT "뇾涓鼁覔", c26, instr("뇾涓鼁覔", c26) AS x FROM test1 ORDER BY "뇾涓鼁覔", c26;

What changes are included in this PR?

How are these changes tested?

andygrove avatar Oct 24 '25 15:10 andygrove

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.17%. Comparing base (f09f8af) to head (211bb11). :warning: Report is 638 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2645      +/-   ##
============================================
+ Coverage     56.12%   59.17%   +3.04%     
- Complexity      976     1447     +471     
============================================
  Files           119      147      +28     
  Lines         11743    13743    +2000     
  Branches       2251     2360     +109     
============================================
+ Hits           6591     8132    +1541     
- Misses         4012     4388     +376     
- Partials       1140     1223      +83     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Oct 24 '25 16:10 codecov-commenter

For literals btw we still need to support maps and structs https://github.com/apache/datafusion-comet/issues/1937 should we resume work on it?

comphead avatar Oct 27 '25 21:10 comphead