datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard
verified publisher icon apache

chore: Fix Scala code warnings

Open comphead opened this issue 4 months ago • 2 comments

What is the problem the feature request solves?

In https://github.com/apache/datafusion-comet/pull/2254 the profile strict-warnings introduced Build the project with strict-warnings profile enabled and need to fix scala code hygiene issues

make release PROFILES="-Pspark-3.5 -Pstrict-warnings"

Describe the potential solution

No response

Additional context

No response

comphead avatar Aug 28 '25 01:08 comphead

I can work on that

akupchinskiy avatar Aug 28 '25 15:08 akupchinskiy

@comphead My original thought was to work on this module by module and eventually make the whole codebase comply with standard, however by working on https://github.com/apache/datafusion-comet/pull/2558 I reckon that may be too much for PR to cater all hygiene issues at once.

Hence instead I reckon that would be better to tackle one warning at a time for the whole codebase, to make the PR be more focused. Ex: one PR to fix all -Ywarn-numeric-widen issue, so on and so forth. WDYT?

andy-hf-kwok avatar Oct 13 '25 21:10 andy-hf-kwok