datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

chore: Prepare for DataFusion 48.0.0

Open andygrove opened this issue 7 months ago • 2 comments

Which issue does this PR close?

Closes https://github.com/apache/datafusion-comet/issues/1709

Rationale for this change

What changes are included in this PR?

How are these changes tested?

andygrove avatar May 02 '25 20:05 andygrove

failures are due to return_field_from_args should be called instead

andygrove avatar May 02 '25 23:05 andygrove

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.60%. Comparing base (f09f8af) to head (2b2b085). Report is 200 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1710      +/-   ##
============================================
+ Coverage     56.12%   58.60%   +2.47%     
- Complexity      976     1138     +162     
============================================
  Files           119      130      +11     
  Lines         11743    12663     +920     
  Branches       2251     2362     +111     
============================================
+ Hits           6591     7421     +830     
- Misses         4012     4058      +46     
- Partials       1140     1184      +44     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 04 '25 19:05 codecov-commenter

Is it possible to have arrow-rs 55.1.0 in datafusion 48.0.0.? A performance improvement went in for int8/int16 which was as a result of the unsigned int issues we raised. The perf improvement also addresses the unsigned int issue which will allow us to clean up a lot of code/tests.

parthchandra avatar May 20 '25 17:05 parthchandra

Is it possible to have arrow-rs 55.1.0 in datafusion 48.0.0.? A performance improvement went in for int8/int16 which was as a result of the unsigned int issues we raised. The perf improvement also addresses the unsigned int issue which will allow us to clean up a lot of code/tests.

DataFusion main branch already uses arrow-rs 55.1.0: https://github.com/apache/datafusion/blob/963b649d1e021e2516c2d652a8aa9fc486a5a1ba/Cargo.toml#L91

andygrove avatar May 20 '25 19:05 andygrove