We do not respect ignoreNulls in first_value / last_value aggregates

[andygrove]

Describe the bug

When creating the native plan for first_value / last_value aggregates, we currently hard-code ignoreNulls instead of using the value from the protobuf encoding:

                AggregateExprBuilder::new(Arc::new(func), vec![child])
                    .schema(schema)
                    .alias("first")
                    .with_ignore_nulls(false)  <-- this should not be hard-coded!

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

[anuragmantri]

I will take a look at this one.

[andygrove]

I will take a look at this one.

Thanks @anuragmantri. There is a closely related issue https://github.com/apache/datafusion-comet/issues/1646 that you may want to look at as well.

[andygrove]

Althtough this is a bug and a correctness issue, it is not a regression from 0.7.0 behavior, so I am changing the milestone to 0.9.0

[dharanad]

This issues seems to addressed. Should we close this @andygrove

[hsiang-c]

take