Follow on to check that ANSI tests for decimal div are working as intended

Open andygrove opened this issue 9 months ago • 1 comments

What is the problem the feature request solves?

There is a bug fix in https://github.com/apache/datafusion-comet/pull/1512 and I was surprised that the ANSI test were working with Spark 4. This is a follow-on issue to investigate so that we can merge the PR for the 0.7.0 release. Spark 4 is not officially supported yet so I did not want to block the release waiting on merging this PR.

Describe the potential solution

No response

Additional context

No response

Mar 13 '25 20:03 andygrove

spark.comet.ansi.enabled defaults to true in spark 4+, so is the new test case in #1512 as expected?

https://github.com/apache/datafusion-comet/blob/382ac938f2d10666eefc08ec5c1c82025ddf3726/common/src/main/scala/org/apache/comet/CometConf.scala#L578-L585

https://github.com/apache/datafusion-comet/blob/382ac938f2d10666eefc08ec5c1c82025ddf3726/common/src/main/spark-4.0/org/apache/comet/shims/ShimCometConf.scala#L24

Mar 20 '25 06:03 wForget