datafusion-ballista icon indicating copy to clipboard operation
datafusion-ballista copied to clipboard

There are bugs in the yarn build github misses but break our internal build

Open avantgardnerio opened this issue 3 years ago • 0 comments

Describe the bug

Github actions to not yet perform the yarn build step that is now required to make a fully functioning Ballista scheduler artifact. Due to this, there are warnings that are treated as errors in CI that break S&T internal circleci but are not caught by github actions.

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

src/App.tsx
  Line 22:23:  'Query' is defined but never used        @typescript-eslint/no-unused-vars
  Line 22:30:  'QueryStatus' is defined but never used  @typescript-eslint/no-unused-vars

src/components/QueriesList.tsx
  Line 29:18:  'DateCell' is defined but never used      @typescript-eslint/no-unused-vars
  Line [31](https://github.com/apache/arrow-ballista/actions/runs/3115571940/jobs/5052601990#step:4:32):30:  'GrPowerReset' is defined but never used  @typescript-eslint/no-unused-vars


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

To Reproduce

Set up your own CI that has yarn build.

Expected behavior

Both CIs work.

avantgardnerio avatar Sep 23 '22 20:09 avantgardnerio