datafusion-ballista icon indicating copy to clipboard operation
datafusion-ballista copied to clipboard

CLI uses ballista context instead of datafusion context in local mode

Open r4ntix opened this issue 3 years ago • 1 comments

Which issue does this PR close?

Closes #219

Rationale for this change

See #219

What changes are included in this PR?

  • add concurrent_tasks parameter for ballista local mode, default to all available cores
  • use BallistaContext instead of SessionContext
  • use BallistaError instead of DataFusionError

Are there any user-facing changes?

add concurrent_tasks parameter for ballista local mode, default to all available cores

r4ntix avatar Sep 20 '22 03:09 r4ntix

This is looking good. Thanks @r4ntix. I left some feedback.

andygrove avatar Sep 22 '22 02:09 andygrove

This is looking good @r4ntix. Did you need any help with the CI failures?

failures:
    context::tests::test_aggregate_func
    context::tests::test_ballista_show_tables
    context::tests::test_show_tables_not_with_information_schema

andygrove avatar Sep 29 '22 01:09 andygrove

@r4ntix I took the liberty of merging latest from master and fixing merge conflicts

andygrove avatar Sep 29 '22 14:09 andygrove

@r4ntix I took the liberty of merging latest from master and fixing merge conflicts

Thank you very much for helping to fix the remaining issues, I will keep learning and contributing to ballista :)

r4ntix avatar Sep 30 '22 07:09 r4ntix