datafusion-ballista icon indicating copy to clipboard operation
datafusion-ballista copied to clipboard

[WIP]Enable code coverage in pull request.

Open Ted-Jiang opened this issue 3 years ago • 6 comments

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Ted-Jiang avatar Sep 09 '22 09:09 Ted-Jiang

@andygrove Sorry there is still something missing. I will fix it let the report appear in UI.

Ted-Jiang avatar Sep 12 '22 02:09 Ted-Jiang

I think we should create this project in https://app.codecov.io/ , but i am not the owner of the repo 😂

https://codecov.io/upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=&branch=add_code_cov&commit=80dc926f2f4c3edd89be24b1056a0528c09d370f&build=3026474487&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Farrow-ballista%2Factions%2Fruns%2F3026474487&name=&tag=&slug=apache%2Farrow-ballista&service=github-actions&flags=&pr=198&job=Rust&cmd_args=
{'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}

Ted-Jiang avatar Sep 12 '22 02:09 Ted-Jiang

from the log coverage success but fail at push result

|| ballista-cli/src/main.rs: 1/45
|| benchmarks/src/bin/nyctaxi.rs: 0/61
|| benchmarks/src/bin/tpch.rs: 219/639
|| examples/src/bin/dataframe.rs: 1/14
|| examples/src/bin/sql.rs: 1/15
|| python/src/pyarrow_filter_expression.rs: 0/14
|| python/src/utils.rs: 0/2
|| 
49.82% coverage, 4008/8045 lines covered

Ted-Jiang avatar Sep 29 '22 12:09 Ted-Jiang

in report coverage

Run bash <(curl -s https://codecov.io/bash)

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-1.0.6


==> git version 2.37.3 found
==> curl 7.68.0 (x86_6[4](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:5)-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS brotli GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets
==> GitHub Actions detected.
    Env vars used:
      -> GITHUB_ACTIONS:    true
      -> GITHUB_HEAD_REF:   add_code_cov
      -> GITHUB_REF:        refs/pull/198/merge
      -> GITHUB_REPOSITORY: apache/arrow-ballista
      -> GITHUB_RUN_ID:     3026474487
      -> GITHUB_SHA:        80dc926f2f4c3edd89be24b10[5](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:6)[6](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:7)a0528c09d3[7](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:8)0f
      -> GITHUB_WORKFLOW:   Rust
->  Issue detecting commit SHA. Please run actions/checkout with fetch-depth > 1 or set to 0
    current dir:  /home/runner/work/arrow-ballista/arrow-ballista
    project root: .
    Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Reading reports
    + ./cobertura.xml bytes=246999
==> Appending adjustments
    https://docs.codecov.io/docs/fixing-reports
    -> No adjustments found
==> Gzipping contents
        24K	/tmp/codecov.chHZNt.gz
==> Uploading reports
    url: https://codecov.io
    query: branch=add_code_cov&commit=[8](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:9)0dc[9](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:10)26f2f4c3edd89be24b[10](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:11)56a0528c09d370f&build=3026474487&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Farrow-ballista%2Factions%2Fruns%2F3026474487&name=&tag=&slug=apache%2Farrow-ballista&service=github-actions&flags=&pr=198&job=Rust&cmd_args=
->  Pinging Codecov
https://codecov.io/upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=&branch=add_code_cov&commit=80dc926f2f4c3edd89be24b1056a0528c09d370f&build=3026474487&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Farrow-ballista%2Factions%2Fruns%2F3026474487&name=&tag=&slug=apache%2Farrow-ballista&service=github-actions&flags=&pr=198&job=Rust&cmd_args=
{'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}
404
==> Uploading to Codecov
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 [24](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:25)639  100   108  100 245[31](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:32)    [44](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:45)6    98k --:--:-- --:--:-- --:--:--   99k
    {'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}

Ted-Jiang avatar Sep 29 '22 12:09 Ted-Jiang

I think we should create this project in https://app.codecov.io/ , but i am not the owner of the repo

I am also unable to do this. Maybe @alamb can remember how we set this up for the other repos?

andygrove avatar Sep 29 '22 14:09 andygrove

I am also unable to do this. Maybe @alamb can remember how we set this up for the other repos?

I do not remember ever setting it up. When I tried to log into codecov it wanted access to my private repos, which I am not willing to allow and thus I can't see the app at all.

alamb avatar Sep 29 '22 17:09 alamb