apache
feat(scheduler): add csv support for get_file_metadata grpc method
Which issue does this PR close?
Closes #.
I was exploring the code and came across the TODO about the csv file format support. So decided to address it.
Rationale for this change
The functionality extension.
What changes are included in this PR?
- add
csv/tlbfile format support - fix minor typos
Are there any user-facing changes?
No
@andygrove Could you please take a look at this change when you have time? Provided that there were no open ticket (but only todo in the code) I understand that maybe this change is of no use.
~UPD: I will resolve the failing checks if we decide to proceed with this PR.~
@andygrove just a ping in case this notification is lost. Could you please take a look?
Thank you for the feedback @Dandandan I'll resolve the conflicts and address your comments in the next couple of days!
@Dandandan @etolbakov get_file_metadata has been removed from latest code (#1110). it was not clear what it was used for, no documentation nor any of the internal ballista code was using it.
can you please elaborate what was the point of it ?
@milenkovicm @Dandandan sorry for the confusion, as per description I was exploring the code and came across the TODO about the csv file format support. So decided to address it. If it doesn't seem to be useful enough or creates more hassle we can close the ticket. I'm happy to look into something else.
As project was not actively maintained and lot of work accumulated we decide to change project's scope and remove code so maintainers have smaller code base to maintain ( some details in #1067 ). This specific functionality has been removed as there is no clear benefit of keeping it.
Currently, there is active work ongoing towards #974
@etolbakov if you wish to contribute please join discord channel, there are ongoing discussions on tasks and priority
@milenkovicm makes sense! Thanks! I’m already in the discord, will check the ballista stream. Happy if you close the issue.