Unsupported characterset

[susmita-m145]

Jira- DAFFODIL-2049

[susmita-m145]

Kindly review my changes

[stevedlawrence]

It would also be really helpful to add a test so that this new code has some test coverage to make sure we don't accidentally break this in the future.

It looks like we have similar tests in daffodil-test/src/test/resources/org/apache/daffodil/section10/representation_properties/encodings.tdml. The easiest way to add this test would be to:

1. Copy the eString element to make a new element with this new encoding
2. Copy the ebcidc1 parserTestCase to create a new parserTestCase with a unique name and that uses your new element as the root

With that done, you just need to modify daffodil-test/src/test/scala/org/apache/daffodil/section10/representation_properties/TestRepProps2.scala and copy def test_ebcdic1 to run your new parser test case.

[mbeckerle]

@susmita-m145 we're moving towards release 3.1.0 soon. I'd like to get this charset in. Can you fix the review-comments issues?

[mbeckerle]

Charsets are now pluggable as of daffodil git hash c81b213b02ac414a39290787cf2eea14d83fdc26, so this can be done as a dynamically loaded charset extension now.

I'm not at all opposed to building this into the charsets that come with Daffodil. I just want to point out that the sands have shifted a little under this.

[mbeckerle]

Closing as inactive. The ticket points back to this work if useful.