daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

WIP: Add noPretty to disable pretty print for XML and JSON formats

Open gezapeti opened this issue 4 years ago • 4 comments

DAFFODIL-2234

I'm not sure this is the correct way to implement this option. I couldn't figure out a way to place it in a subcommand, so I went with a general command there. No tests yet, I wanted to clarify if the path is correct.

gezapeti avatar Mar 02 '20 14:03 gezapeti

I've been looking around and maybe I should start with DAFFODIL-1958 and that would make this one easier as well.

gezapeti avatar Mar 02 '20 15:03 gezapeti

Potentially. DAFFODIL-1958 would be a really nice bug to resolve. The entire CLI is basically one giant function. Cleaning up the Scallop config is the first step in making that main function easier to update and manage. Definiately a worthy bug to work on.

stevedlawrence avatar Mar 02 '20 15:03 stevedlawrence

I think we at the least need to move the option out of the global options and into the parse options. Also, keep in mind that although it's a small, it could be considered part of the CLI "API", so changing things later potentially has issues with backwards compatibilty.

But as long as this is moved out of the global options I'm fine with this change.

stevedlawrence avatar Apr 08 '20 14:04 stevedlawrence

I've stopped working on this one and started with DAFFODIL-1958, but I find it hard to wrap my head around the logic of scallop - and working from home eats up all the free cycles I could spend on that. I'm fine with moving the option to parsing option and we can change things under the hood if the option name itself is good.

gezapeti avatar Apr 10 '20 20:04 gezapeti

Closing as inactive. DAFFODIL-2234 links back here for future reference.

mbeckerle avatar Feb 06 '24 19:02 mbeckerle