cxf icon indicating copy to clipboard operation
cxf copied to clipboard

CXF-8700: Eliminate the `java.compiler` dependency from cxf-core

Open rotty3000 opened this issue 3 years ago • 6 comments

Signed-off-by: Raymond Augé [email protected]

rotty3000 avatar May 07 '22 15:05 rotty3000

enabling Karaf debug settings in org.apache.cxf.systest.sts.itests.BasicSTSIntegrationTest didn't work :(

rotty3000 avatar May 11 '22 00:05 rotty3000

enabling Karaf debug settings in org.apache.cxf.systest.sts.itests.BasicSTSIntegrationTest didn't work :(

@rotty3000 could you please uncomment KarafDistributionOption.keepRuntimeFolder(), (BasicSTSIntegrationTest), I will fetch the distribution and logs right after the build.

reta avatar May 11 '22 00:05 reta

@reta done!

rotty3000 avatar May 11 '22 13:05 rotty3000

@reta done!

Could see a few things:

system.properties:

org.ops4j.pax.url.mvn.localRepository=/home/jenkins/workspace/CXF/CXF-JDK11-PR/.repository

/home/jenkins/workspace/CXF/CXF-JDK11-PR/.repository has cxf-tools-compiler published but the bundle is not installed:

karaf@root()> la | grep -i compiler
karaf@root()>

Looking why PAX does not seem to pick the artifacts.

reta avatar May 11 '22 14:05 reta

Oh, I see all checks have now passed :)

rotty3000 avatar May 12 '22 15:05 rotty3000

Thanks for the pull request @rotty3000! My apologies for the delay looking into it. May I ask you please to split this request into smaller ones. It seems like you have bundled java.desktop and java.compiler + other changes together but there are separate tickets for it (CXF-7000, CXF-7001 created by you). The compiler changes look good to me (besides the compatibility comments) but I do have questions to java.desktop related changes.

reta avatar May 28 '22 19:05 reta