cxf icon indicating copy to clipboard operation
cxf copied to clipboard

[CXF-5052] Classpath references should be understood using wsdlRoot batch processing options in cxf-codegen

Open oli-ver opened this issue 6 years ago • 7 comments

First proposal for a classpath replacement of local file url in generated class file.

A wsdlPath set in defaultOptions beginning with classpath; replaces the file url "file:/path/to/package1/package2/myfile.wsdl" with "classpath:/package1/package2/myfile.wsdl".

Just the first idea on how to achieve this, I am very open for different ideas.

oli-ver avatar Feb 23 '18 18:02 oli-ver

Thanks for your PR. Could you please add a testcase to the src/it folder? There are already two testcases so just copy and adapt one of them...

deki avatar Feb 25 '18 10:02 deki

@deki I added a testcase, but I am not sure, how it should be executed. Nevertheless: When I run mvn generate-sources in the folder src/it/wsdl-classpath-resolution the example generates classes with classpath URLs.

oli-ver avatar Feb 25 '18 12:02 oli-ver

@oli-ver this could be part of the 3.2.5 release. are you able to finish it?

deki avatar Jun 05 '18 12:06 deki

@deki Sorry for my contiously late answers. What is the due date for 3.2.5? Are you ok with the solution I suggested here, when the tests do work? I personally think it is better to have a special XML node for this, but I would have to figure out how to create new ones first and find time to implement it. Sorry, at the moment there are too many other things going on :)

oli-ver avatar Jun 13 '18 08:06 oli-ver

The release is planned for today.

Regarding your solution: Why not using classpath: instead of classpath;?

deki avatar Jun 18 '18 14:06 deki

I did not want the expression to look like a classpath, because it‘s only a replacement string. Do you think classpath: would be a better syntax?

oli-ver avatar Jun 19 '18 07:06 oli-ver

Ah ok got it. I this case a separate tag would be cleaner to avoid confusion.

deki avatar Jun 19 '18 08:06 deki