cxf icon indicating copy to clipboard operation
cxf copied to clipboard

[CXF-7455] Tolerate missing message part

Open semancik opened this issue 7 years ago • 7 comments

semancik avatar Jul 26 '17 15:07 semancik

Thanks for your pull request. Can you provide a unit/ integration test for this?

deki avatar Jul 27 '17 07:07 deki

Looks like this has been already worked around in the winrm4j project. I was not aware of that. So I might actually cancel the pull request later on. Please, bear with me, I need some time to explore. However, I would say that it is rather sad that it is easier to work around the problem than to deal with all this checkstyle pain, unit tests and so on.

semancik avatar Jul 27 '17 08:07 semancik

No need to cancel the PR, if we could make the code more robust, we should do that.

deki avatar Jul 27 '17 16:07 deki

I was looking around how to construct a test for this. But I'm really puzzled. There seems to be very little documentation about writing tests. And I could not find any test that would be similar to what I'm trying to do.

I have SOAP message that is causing the exception. It is a SOAP response from the server. How do I create a simple test that just attempts to process the message, runs the interceptors and checks the processed message?

semancik avatar Aug 14 '17 08:08 semancik

Ok could you please attach the SOAP message to the JIRA issue?

Regarding test you can take a look at the existing org.apache.cxf.jaxws.holder.HolderTest.

Btw. PRs should usually point to master, we will take care of merging them to the other branches.

deki avatar Aug 23 '17 13:08 deki

@semancik any chance to get the SOAP message that reproduces the issue?

deki avatar Jun 05 '18 12:06 deki

I'm sorry. I was lucky enough not to be forced to deal with that terrible Microsoft technology in the meantime. And I'm quite scared to look there just by myself unless I really have to. Please bear with me. But I'll do it ... sooner or later.

semancik avatar Jun 06 '18 06:06 semancik