couchdb icon indicating copy to clipboard operation
couchdb copied to clipboard

change --enable-{nouveau,clouseau} to --with-

Open rnewson opened this issue 1 year ago • 4 comments

We've decided that CouchDB should not alter default.ini in the release tarball if you enable either or both of the search add-ons. That activation should be done by our packages or by the system administrator.

We change the configure flags from --enable to --with to indicate that these components will only be built and included in the release artifact.

rnewson avatar Jun 28 '24 11:06 rnewson

Please consider the following other occurrences as well:

% fgrep -r "enable-clouseau"
./README-DEV.rst:    ./configure --enable-clouseau
./build-aux/Jenkinsfile.full:    result += " --enable-clouseau"
./build-aux/Jenkinsfile.pr:./configure --enable-nouveau --enable-clouseau --js-engine=${JS_ENGINE}
./build-aux/Jenkinsfile.pr:          ./configure --spidermonkey-version 78 --enable-nouveau --enable-clouseau
./.devcontainer/devcontainer.json:    "postCreateCommand": "./configure --enable-nouveau --enable-clouseau && make",
./dev/run:        else "./configure --enable-clouseau"

pgj avatar Jun 28 '24 16:06 pgj

@pgj oh good find, maybe the same fgrep command should be run for —enable-nouveau?

big-r81 avatar Jun 28 '24 17:06 big-r81

@pgj oh good find, maybe the same fgrep command should be run for —enable-nouveau?

Yep, that is a good idea.

pgj avatar Jun 28 '24 18:06 pgj

updated, and a jenkins-with-nouveau branch pushed as suggested.

rnewson avatar Jul 01 '24 17:07 rnewson