couchdb-fauxton icon indicating copy to clipboard operation
couchdb-fauxton copied to clipboard

Support pagination in ReplicatorDB activity panel

Open popojargo opened this issue 4 years ago • 5 comments

Overview

Add support for pagination in Replicatory activity panel.

Testing recommendations

GitHub issue number

Related Pull Requests

Supersed #1075

Checklist

  • [ ] Code is written and works correctly;
  • [ ] Changes are covered by tests;
  • [ ] Documentation reflects the changes;
  • [ ] Update rebar.config.script with the correct tag once a new Fauxton release is made

popojargo avatar Jun 09 '20 04:06 popojargo

@garrensmith @Antonio-Maranhao Do I have to make some magic for partitioned database?

popojargo avatar Jun 09 '20 04:06 popojargo

In inspected the commit https://github.com/apache/couchdb-fauxton/pull/1288/commits/a35a657a75d2e046b6699da09be0044be3170e68 and, insofar as I understand it, it all looks good to me. I do see that the commit contains fixes for the specific faults pointed out by @Antonio-Maranhao at https://github.com/apache/couchdb-fauxton/pull/1288#pullrequestreview-429124811

I have played with it a bit (I created 110 continuous replications to do so) and did not find anything wrong with it.

So +1 from me, if that counts for anything.

brianewilkins avatar Mar 18 '21 22:03 brianewilkins

@popojargo sorry for the delay. I'll make time to review this today or tomorrow.

Antonio-Maranhao avatar Mar 29 '21 15:03 Antonio-Maranhao

Besides my suggestion, just wanted to point out that column sorting and filtering only affect the docs in the current page, which I'm sure it'll mislead users.

Maybe it'd be worth adding a note at the top @popojargo @brianewilkins ?

Brainstorming here:

  • We could maybe add a tooltip to the sort buttons? That said, that would be a bit repetitive.<
  • Another variant of the tooltip could be to add a tooltip to the right of the action bar. We would only have one tooltip for all sort buttons.
  • We could add a note above the table. That would take some height some something that might not be important?

popojargo avatar Apr 11 '21 23:04 popojargo

@popojargo I'd go with a note above the table. The tooltips are probably too repetitive as you said and less obvious.

Antonio-Maranhao avatar Apr 12 '21 17:04 Antonio-Maranhao