cordova-serve icon indicating copy to clipboard operation
cordova-serve copied to clipboard

feat: forward the CLI user arguments to cordova-serve/browser

Open timbru31 opened this issue 4 years ago • 3 comments

This closes #18. As @Max104t said their account is locked, I've gone ahead and forked the fork to retain the original commit author.

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • [x] I've run the tests to see all new and existing tests pass
  • [ ] I added automated test coverage as appropriate for this change
  • [ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [ ] I've updated the documentation if necessary

timbru31 avatar Feb 17 '21 10:02 timbru31

Merging in tomorrow if no veto's arise.

timbru31 avatar Apr 06 '21 13:04 timbru31

Since this is a minor change, I think someone should create a PR to pin the repo for a minor release 4.1.0-dev.

erisu avatar Apr 14 '21 03:04 erisu

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (ea89b6e) to head (a816a3d). Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/browser.js 80.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #42       +/-   ##
===========================================
+ Coverage   28.11%   40.45%   +12.34%     
===========================================
  Files           6        6               
  Lines         217      220        +3     
===========================================
+ Hits           61       89       +28     
+ Misses        156      131       -25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 02 '24 05:09 codecov-commenter