cordova-plugin-wkwebview-engine icon indicating copy to clipboard operation
cordova-plugin-wkwebview-engine copied to clipboard

fix(ios): Avoid infinite loop on cancelled navigation

Open gwynjudd opened this issue 5 years ago • 1 comments

Fixes #83 Ref https://github.com/apache/cordova-ios/pull/334

Platforms affected

iOS

Motivation and Context

Fixes #83

Description

Similar as the fix in https://github.com/apache/cordova-ios/pull/334. It has the same symptoms.

The change is to not try to load the error URL in the event that didFailNavigation occurred in response to a cancelled navigation.

Testing

The issue seems to be timing related. I found that it did not always replicate, depending on the device, and which server we were connecting to. As such, it is hard to produce an exact set of steps. But I found that for the servers against which we were always seeing the issue (100% replication), it no longer occurred.

Checklist

  • [ x ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

gwynjudd avatar Mar 18 '19 20:03 gwynjudd

I have the same issue

sirlantj avatar Apr 16 '19 13:04 sirlantj

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.

jcesarmobile avatar Jan 08 '23 23:01 jcesarmobile