CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar

[aszmyd]

Platforms affected

Android

What does this PR do?

1. It makes statusbar transparency persisten. Earlier when you call methods in this order: overlaysWebView(true) , hide() , show() the status bar gets shown without transparency and pushes webview to bottom. And because we wanted to have statusbar transparent (overlaysWebView) from this point the show/hide should toggle the statusbar visibility and it should always show transparent.
2. Support for StatusBarOverlaysWebView in Android when its pre-defined in project config.xml

What testing has been done on this change?

Manual testing on Android device

Checklist

• [x] Reported an issue in the JIRA database
• [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• [ ] Added automated test coverage as appropriate for this change.

[aszmyd]

@janpio whats needed to get this merged? I've pushed fixes to the way i accessed transparent from another thread as this.transparent did not work during build.

[janpio]

Someone of the committers/maintainers with enough Android experience has to be convinced enough that he hits the merge button. I am not, as I have only superficial knowledge of Android. Enough to leave some comments on code, but not enough to actually be sure the code will be ok in production.

[aszmyd]

@janpio do you have anyone specific in mind? Maybe @infil00p can jump in here? I see he merged other Android codes in this repo.

[janpio]

Unfortunately not. You could try emailing the Dev mailing list, see https://cordova.apache.org/contact/.

[janpio]

@aszmyd Some feedback from other commiters I got when asking for a review of this:

doesn't have JIRA issue :thumbsdown: just saying we have hundreds of unattended PRs and I won't give priority to the ones that don't follow the rules

Could you please create said issue and add it to the PR? Open a new one to get the "usual" template for a PR. Thanks.

(If changing the commit message is to involved for you, we can fix that when/if merging)

[aszmyd]

@janpio I've created JIRA issue: https://issues.apache.org/jira/browse/CB-14238 and renamed PR name and description. Not sure if i should also rename commit name and force git push? It could confuse others that already pulled this branch.

[brody4hire]

@aszmyd it should be fine to update by force push (we do this kind of thing all the time). Alternative solution which I think is not necessary is to simply open a new PR. Even fancier is to open a new PR with text like "resolves #99" or "closes #99" in the description (https://help.github.com/articles/closing-issues-using-keywords/).

As an aside you may want to maintain your own special fork version until we get a chance to deal with this one. Maybe something like "cordova-plugin-statusbar-transparent" or "cordova-plugin-persistent-statusbar"?

[aszmyd]

@brodybits thanks. I've pushed clean one commit with name changed.

[brody4hire]

A couple minor points FYI:

• First line should generally be within 50 characters. If you need more then you should add a blank line then keep remaining lines within 70 characters. This is very well documented, for example: https://chris.beams.io/posts/git-commit/. AFAICT we generally take care of this formatting issue if needed.
• Unless there is good reason to keep multiple original commits we will very likely do a "squash merge", which means that the master branch would actually diverge from your proposed android-persistent-transparency branch.

Thanks for the contribution, I am sure it will help others in the future.

[aszmyd]

I do not know why travis build failed for safari browser.

[janpio]

I restarted the failed Travis jobs manually.