cordova-plugin-screen-orientation icon indicating copy to clipboard operation
cordova-plugin-screen-orientation copied to clipboard

ci: Upgrade build tools to use modern tooling & device profiles

Open breautek opened this issue 4 years ago • 1 comments

Platforms affected

CI

Motivation and Context

Progresses https://github.com/apache/cordova/issues/223

Description

Updates CI configs to use modern tooling and device profiles.

Testing

Ran npm test

Checklist

  • [x] I've run the tests to see all new and existing tests pass
  • [x] I added automated test coverage as appropriate for this change
  • [x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [x] I've updated the documentation if necessary

breautek avatar Feb 28 '21 15:02 breautek

Test is failing on desktop browsers for this reason: https://github.com/apache/cordova-plugin-screen-orientation/issues/35#issuecomment-658536587

Desktop browsers now implements the APIs, so we use them, but they will reject as you can't lock an orientation on desktop.

On rejection, we will fallback to a cordova bridge, but we don't actually have a browser implementation for the fallback, thus resulting to cordova.js:1001 Error: exec proxy not found for :: CDVOrientation :: screenOrientation message.

It sounds like these tests are going to have to be spied on to simulate, but we also should probably return a meaningful message when running in an environment that doesn't actually support orientation locking.

I haven't tested yet, but I assume this works as intended in the mobile browser.

breautek avatar Feb 28 '21 16:02 breautek

Closing because we have moved away from appveyor/travis making this PR obsolete.

breautek avatar Sep 21 '22 23:09 breautek