cordova-plugin-network-information icon indicating copy to clipboard operation
cordova-plugin-network-information copied to clipboard

Published 20 hours ago • verified publisher icon apache

5G detection

Open ath0mas opened this issue 4 years ago • 13 comments

Feature Request

Motivation Behind Feature

5G connectivity starts to be available on modern Android and iOS devices: since Android 11 and iOS 14/iPhone 12.

Feature Description

Detect 5G network and return 5g, from new value CELL_5G: '5g' to be added in Connection.js exports.

  • suggested API call for Android: https://developer.android.com/about/versions/11/features/5g#detection
  • TBD for other platforms

Alternatives or Workarounds

Don't know.

ath0mas avatar Oct 18 '20 16:10 ath0mas

PR's welcome!

timbru31 avatar Oct 18 '20 17:10 timbru31

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

paulieo10 avatar May 10 '21 08:05 paulieo10

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

I will do a PR with the improvements for 5g. I already tested with android but I still some time for ios.

ZumelzuR avatar May 12 '21 18:05 ZumelzuR

https://github.com/apache/cordova-plugin-network-information/pull/130

ZumelzuR avatar May 13 '21 08:05 ZumelzuR

Is there anything new on this problem? The PR is open for almost a year :thinking:

cels avatar Apr 07 '22 07:04 cels

Sorry was impossible for me to do the fixes they required for the MR. I did it today so hope they approve :D

ZumelzuR avatar Apr 07 '22 14:04 ZumelzuR

Thanks a lot!

cels avatar Apr 12 '22 12:04 cels

Anything new here? Is there a plan when this will be merged?

cels avatar Jul 29 '22 08:07 cels

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

mdivya-symplr avatar Oct 03 '22 04:10 mdivya-symplr

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

He doesn't have write access to the repository, only Apache members can merge it in.

Looking at the PR it looks like it's marked as a breaking change, so it won't be merged in until we prepare the main branch as a major release. Right now it's prepared as a patch release.

Additionally it only has 1 approved review, and usually we like to see at least 2 approved reviews from Apache members. Others are also welcome to review/test the PR.

breautek avatar Oct 03 '22 11:10 breautek

I dont know how to fix the ios12 test fail, if someone can lead me on this I could try to fix what is missing to be approved. Anyway for the moment feel free to use my fork https://github.com/ZumelzuR/cordova-plugin-network-information

ZumelzuR avatar Oct 05 '22 08:10 ZumelzuR

Happy to help but the logs for this run have expired and are no longer available.

BigBalli avatar Oct 13 '22 02:10 BigBalli

Happy to help but the logs for this run have expired and are no longer available.

Same here, how we can run this again?

ZumelzuR avatar Oct 13 '22 11:10 ZumelzuR