cordova-plugin-media
cordova-plugin-media copied to clipboard
Fix for CB-10882 : Plugin Media - "cordova-plugin-media" 2.2.0 seem have a "position" bug with mediaSound.getCurrentPosition method
…ave a "position" bug with mediaSound.getCurrentPosition method.
Added a Check for Recorder also in 'getCurrentPositionAudio'
When I play a mp3 in 2.2.0 @ ios. No sound come out. I am not sure it related to this fix or not.
@ThillaiganeshChan, please update this PR's title to use the correct JIRA ticket number. The title for CB-10822 is "Deduplicate common logic for storing modules metadata in cordova_plugins.js
" and is not related to this change
@sonicwong it's not related to this as this PR is related to getPosition for recordings.
There was however, recently a PR merged that fixed playback of local files where no protocol prefix was set.
I would suggest trying the latest version of the plugin installed directly from github with:
cordova plugin add https://github.com/apache/cordova-plugin-media.git
hi @ThillaiganeshChan and @vladimir-kotikov I am the bug reporter is there anything update ? or ... https://issues.apache.org/jira/browse/CB-10882
Cordova CI Build has one or more failures.
Commit - Link Dashboard - Link
Builder Name | Console Output | Test Report | Device Logs |
---|---|---|---|
Windows 8.1 Store | Link | Link | Link |
Windows 10 Store | Link | Link | Link |
Windows 8.1 Phone | Link | Link | Link |
iOS | Link | Link | Link |
Android Mac | Link | Link | Link |
Let there be tests
Cordova CI Build has one or more failures.
Commit - Link Dashboard - Link
Builder Name | Console Output | Test Report | Device Logs |
---|---|---|---|
Windows 8.1 Store | Link | Link | Link |
Windows 10 Store | Link | Link | Link |
Windows 8.1 Phone | Link | Link | Link |
iOS | Link | Link | Link |
Android Mac | Link | Link | Link |
hello guys this bug have been reported three months ago https://issues.apache.org/jira/browse/CB-10882 is there any update or ... ???
Just reading through your steps to reproduce in Jira and wanted to check where you are seeing the problem.
First you make a recording (this seems to work).
You then call getCurrentPosition().
Before calling getCurrentPosition(), have you stopped the recording, saved it and then created a new media object with the recording as SRC, called media.play() and then getCurrentPosition()?
I am going to do some testing and have a look at it, I just want to be really clear about where the problem is.
hi @ghenry22,thanks your reply
in "cordova-plugin-media" 2.2.0 yes,Before calling getCurrentPosition(), I stop the recording,after that,use getCurrentPosition()
but in "cordova-plugin-media" 2.3.0,I can't reproduce it,because it seem appear another problem https://issues.apache.org/jira/browse/CB-11418
you can try 2.2.0 or 2.3.0,you will know what I mean
well...@ghenry22 7 days passed is there any unclear or anything that I should explain once again ?
2 months passed anything wrong ?
really sad... https://issues.apache.org/jira/browse/CB-11867 this is a critical bug!but Cordova team Disregard it for a long time...
@ThillaiganeshChan way still not solve the problem https://github.com/apache/cordova-plugin-media/pull/87/commits/4deef091a3fe55f20d929a103d71d4c1747e5ab3
Pull Requests are welcome
fixed by myself...
how did you fix it?
hi @jcesarmobile mediaRec.stopRecord(); if(navigator.userAgent.match(/iPad|iPhone|iPod/i)) { mediaRecord.release(); //otherwise,it will crash immediately } if(navigator.userAgent.match(/Android/i)) { //do nothing,if use "release" method too,it will cause "record" method fail}