apache
feat(windows): Functional audio recorder on Windows devices
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist
- [ ] Reported an issue in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
Pay attention to the new options Attribute used in captureAudio call
options.element: A HTML DIV element. If specified, captureAudio creates an audio recorder UI using this div element as parent element in DOM.
You may only regard src/Windows Folder changes for this pull request. If you don't like cordova-cli version backward compatibility, just ignore config.xml change
BTW. Looking at e.g. call of function captureAudio in this repo: apache/cordova-plugin-media-capture:
-
Android: no reproducable function due to random dependency on exeistence of a recorder app on the device. Better, throw away all existing source and reimplement using the MediaRecorder java class
-
Windows: no UI, no interaction, almost no function. Better use at least my pull request for minimal function
-
iOS: Crash on call. no function yet.
Someone else out there could start to work on at least minimal function in the source code on the three main platforms instead of paying attention to useless version numbers or formal phrases. Only a suggestion :/
The conflict is easy enough to fix, but as this PR is coming from master I am hesitant to just update your fork @convey-gilbert. Could you please clean this up?
CI, please rerun tests anyway if possible. Update: Not possible with conflicts it seems :/
The PR used master branch and the OP kept adding changes to it, so current changes are no longer related to the original pull request.
Closing as stale.
Seems like the original change was for the windows platform which is now deprecated.
