cordova-plugin-media-capture
cordova-plugin-media-capture copied to clipboard
apache
Audio Capture - added support for iPhone 6 and iPhone 6 Plus microphone images
Platforms affected
iOS
What does this PR do?
Added microphone images for iPhone 6 and iPhone 6 Plus screen sizes
What testing has been done on this change?
Tested on iPhone 6 and iPhone 6 Plus
Checklist
- [ ] Reported an issue in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
Cordova CI Build has completed successfully.
Commit - Link Dashboard - Link
72 tests run, 0 skipped, 0 failed.
Ping @purplecabbage @shazron for a quick review. Is having these microphone images something we would want?
I am concerned that the images and configuration for this addition seem very device-specific.
they are both device specific, and cordova specific I see these as something that an app developer should be providing themselves, unfortunately there is not an API for this, or a demo/doc of how a developer would do it.
The images already exist for every other device shape and size, so this isn't a new thing, just covering more new devices.
That said, I have never really agreed with the direction of providing a generic UI inside this plugin, ... But, It is probably better to just accept this pr, and move on with another implementation some day when we find the time.
The fact that @momomatteo ;) has taken the time to send this pr should speak much louder than my personal feelings on the subject ...
It is always nice to have, but not specifically required; sending a pr is proof of the intent to contribute.
In this case the graphics are really just resized versions of existing files, so this is a modification. If brand new images were generated then we might need to insist as the ICLA also protects us from someone contributing something they don't have the rights to.
@momomatteo can you put the issue id (CB-12562) on the title so it's linked with the original issue on JIRA?
Also, can you remove one of the #import <Cordova/CDVAvailability.h>? you duplicated it
And finally, after those changes, can you squash all the commits into one?
Leaving this here because I can't find any info elsewhere. Does anyone know why this repo is suddenly empty?
@jaredloson there is some kind of GitHub issue that is causing havoc with read-only mirrors right now. Apache Infra + GitHub are actively working on it.
If you need to access the source, you can always do so via git.apache.org/cordova-plugin-media-capture.git.