cordova-plugin-media-capture icon indicating copy to clipboard operation
cordova-plugin-media-capture copied to clipboard

iOS: Fixed UI sizing for audio capture controller according to parent view size

Open BardRedStar opened this issue 3 years ago • 4 comments

Fixed UI sizing for audio capture controller according to parent view size

Platforms affected

iOS

Motivation and Context

Audio capture controller's view looks different for iPhones and iPads and crops according to the device size. 1 2

Description

I changed the size calculation for the audio capture controller's layout. Now the UI looks good on all devices. 3

Testing

I didn’t find any tests for this plugin.

Checklist

  • [X] I've run the tests to see all new and existing tests pass
  • [X] I added automated test coverage as appropriate for this change
  • [X] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [X] I've updated the documentation if necessary

BardRedStar avatar Jul 31 '20 10:07 BardRedStar

Fixes #176 and #208

ath0mas avatar Feb 09 '21 20:02 ath0mas

@timbru31 see how this PR and few others can be integrated, with resolved conflicts, in the fork I have been successfully using for months now

ath0mas avatar Feb 16 '21 21:02 ath0mas

@timbru31 see how this PR and few others can be integrated, with resolved conflicts, in the fork I have been successfully using for months now

Thank you very much for your support.

I installed the plugin from the fork you created.

These fixes are not available in the main repository?

sdemir60 avatar May 24 '21 14:05 sdemir60

@sdemir60 Yes, as of today nearly all the fixes I merged in my fork are still open PRs on the main repository

ath0mas avatar Jun 03 '21 22:06 ath0mas

I can help on this rebase if it has to be done quickly this week ; tell me @BardRedStar @erisu

ath0mas avatar Aug 07 '23 22:08 ath0mas