cordova-plugin-inappbrowser icon indicating copy to clipboard operation
cordova-plugin-inappbrowser copied to clipboard

Published 20 hours ago • verified publisher icon apache

CB-12479: Add loading spinner for android

Open cjpearson opened this issue 9 years ago • 9 comments

cjpearson avatar Mar 05 '15 16:03 cjpearson

@cjpearson as this was never merged for CB-3750, I've created CB-12479 to track the Android spinner.

Can you change the title to link CB-12479 and also rebase fixing the conflicts?

jcesarmobile avatar Feb 21 '17 19:02 jcesarmobile

This still needs to merge cleanly to be added. Please fix all the conflicts to add this code if you are still interested in adding this PR.

infil00p avatar Sep 21 '17 16:09 infil00p

Hey @cjpearson , there seems to be a merge conflict now. Could you maybe fix this? Thanks.

janpio avatar Sep 16 '18 17:09 janpio

@janpio Done.

cjpearson avatar Sep 28 '18 14:09 cjpearson

Awesome. Unfortunately I have some more "work" for you: I just fixed the problem that caused Android tests to fail in master. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR.

janpio avatar Oct 01 '18 13:10 janpio

Thanks for the rebase, and sorry I didn't check what repo this PR was in before writing this: cordova-plugin-inappbrowser has another test problem. You can follow my progress understanding it here: https://github.com/apache/cordova-plugin-inappbrowser/issues/307

janpio avatar Oct 01 '18 14:10 janpio

@janpio No problem, I had to make another change anyway. The latest commit replaces the deprecated ProgressDialog with a ProgressBar.

cjpearson avatar Oct 01 '18 14:10 cjpearson

(After final changes on our test environment the tests are now passing. Thanks for your help)

janpio avatar Oct 02 '18 19:10 janpio

Any chance this will be merged sometime soon?

shukigu-tr avatar Jul 27 '21 13:07 shukigu-tr