cordova-plugin-inappbrowser
cordova-plugin-inappbrowser copied to clipboard
GH-1025 android: enable window.print()
Platforms affected
Android
Motivation and Context
This change enables usage of window.print()
on Android
Partially implements #1025
Description
window.print is not implemented in Android's WebView. This change adds a print method to the cordova_iab JavaScript interface and overrides window.print to call the new print method.
Testing
- Load up any Cordova application in an Android emulator. (I was using an emulated Pixel 7 Pro API 33)
- Open up the Web Inspector JavaScript Console.
- Run
window.print()
in the console. - The print preview should appear.
I attempted to run the cordova-mobile-spec tests, but encountered an error when running cordova-mobile-spec/createmobilespec/createmobilespec.js --android
.
Error: Module cordova-lib installed in cordova-plugman is not npm-linked. I recommend you run "coho npm-link".
at verifyNpmLinkOf (/Users/victorelci/Projects/cordova-test/cordova-mobile-spec/createmobilespec/createmobilespec.js:337:19)
at Object.<anonymous> (/Users/victorelci/Projects/cordova-test/cordova-mobile-spec/createmobilespec/createmobilespec.js:358:9)
Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with
(platform)
if this change only applies to one platform (e.g.(android)
) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
- [ ] I've updated the documentation if necessary