cordova-plugin-geolocation
cordova-plugin-geolocation copied to clipboard
apache
Android: handle location service is off case and return error
Platforms affected
Android
What does this PR do?
Return error when location is off, same error as return in iOS
What testing has been done on this change?
Bashed application using this version with this change
Checklist
- [ ] Reported an issue in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
Cordova CI Build has completed successfully.
Commit - Link Dashboard - Link
| Builder Name | Console Output | Test Report | Device Logs |
|---|---|---|---|
| Windows 8.1 Store | Link | Link | Link |
| Windows 10 Store | Link | Link | Link |
| Windows 8.1 Phone | Link | Link | Link |
| iOS | Link | Link | Link |
| Android | Link | Link | Link |
Cordova CI Build has completed successfully.
Commit - Link Dashboard - Link
| Builder Name | Console Output | Test Report | Device Logs |
|---|---|---|---|
| Windows 8.1 Store | Link | Link | Link |
| Windows 10 Store | Link | Link | Link |
| Windows 8.1 Phone | Link | Link | Link |
| iOS | Link | Link | Link |
| Android | Link | Link | Link |
If creating a JIRA issue for this PR is the only thing holding it up, here you go...
https://issues.apache.org/jira/browse/CB-12406
@stevengill Is there anything else that needs to be done to get this merged? It seems like quite a key feature to me!
This branch needs merged, it fixes inconsistencies between android and ios and after hours of trying to get android to work with no avail I installed this fork and it worked immediately. yes we can all download it from his fork, but it should be in the main repo. It's a definite improvement.
@khalidaw Why are you returning no error message when you're sending back the ILLEGAL_ACCESS error when the permission is denied?
