cordova-plugin-file icon indicating copy to clipboard operation
cordova-plugin-file copied to clipboard

test(ts): Added a TS compilation check

Open breautek opened this issue 2 years ago • 1 comments
trafficstars

Platforms affected

Motivation and Context

Adds a TS check on our type def files.

Description

Adds Typescript 5.1 as a dev dependency and updates the test script to run tsc to see if our types will at least compile.

There is an empty .ts file as an entry point for tsc, but it could be expanded in the future to actually make use of the API and ensure that types will compile as expected.

Testing

Ran npm test

Tests will fail without a PR fix such as https://github.com/apache/cordova-plugin-file/pull/588

Checklist

  • [x] I've run the tests to see all new and existing tests pass
  • [x] I added automated test coverage as appropriate for this change
  • [x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [x] I've updated the documentation if necessary

breautek avatar Jul 28 '23 18:07 breautek

This all makes sense to me! 🥇

peitschie avatar Aug 01 '23 05:08 peitschie