cordova-plugin-file icon indicating copy to clipboard operation
cordova-plugin-file copied to clipboard

Remove Microsoft's copyright notice from type definition file

Open kputh opened this issue 5 years ago • 3 comments
trafficstars

Bug Report

Problem

The start of your TypeScript type definitions file contains a copyright notice claiming that it belongs to Microsoft:

// Type definitions for Apache Cordova File System plugin
// Project: https://github.com/apache/cordova-plugin-file
// Definitions by: Microsoft Open Technologies Inc <http://msopentech.com>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
//
// Copyright (c) Microsoft Open Technologies, Inc.
// Licensed under the MIT license.

I suspect this is a copy-and-paste-mistake. You should correct it. You may also want to remove the outdated link to the DefinitelyTyped repo.

kputh avatar Jun 24 '20 16:06 kputh

What's the problem here? License is in tact, and the code is licensed under MIT. Removing the copyright notice would be violating the license.

breautek avatar Aug 06 '20 08:08 breautek

I’ll search the commits later, but indeed Microsoft originally authored those files. They were split from DefinetlyTyped to the actual software projects.

timbru31 avatar Aug 06 '20 10:08 timbru31

@purplecabbage Are you able to provide insight on this issue regarding code licensed/owned by a third-party?

breautek avatar Apr 26 '22 20:04 breautek