cordova-plugin-file
cordova-plugin-file copied to clipboard
fix(android): Make getFreeDiskSpace/getFreeExternalStorageSpace consistent to iOS
Platforms affected
Android
What does this PR do?
Adding consistency with IOS method which return bytes and Android return KB. Now both method return the same unit of measurement (bytes)
What testing has been done on this change?
N/A
Checklist
- [ ] Reported an issue in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
Cordova CI Build has completed successfully.
Commit - Link Dashboard - Link
Builder Name | Console Output | Test Report | Device Logs |
---|---|---|---|
Windows 10 Store | Link | Link | Link |
iOS 9.3 | Link | Link | Link |
iOS 10.0 | Link | Link | Link |
Android 4.4 | Link | Link | Link |
Android 5.1 | Link | Link | Link |
@stevengill could you help me find a code reviewer, please?
hey @gattex
sure! Do you have a issue number for this yet? if not, could you create one at issues.cordova.io and share it here?
Hey, why is this still not pushed to master? This is really big inconsistency.
... in an undocumented function of the plugin, right?
Does any internal plugin code depend on this function? Where is it used and why does it exist? Could there be any side effects of this change?
This should be pushed, leaving it as is only causes confusion.