cordova-plugin-dialogs icon indicating copy to clipboard operation
cordova-plugin-dialogs copied to clipboard

Published 20 hours ago • verified publisher icon apache

fix(android): Notifications now stop and clears the channel

Open m1aw opened this issue 6 years ago • 4 comments

Platforms affected

Android

What does this PR do?

Ensures notifications stop after playing. This fixes the issue we had when after 15 notifications, the 16th notification would not play the sound.

What testing has been done on this change?

Use previous version, spam .beep() 16, the 16th notification will not play. Use this version, the issue is fixed.

Checklist

  • [ ] Reported an issue in the JIRA database
  • [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • [ ] Added automated test coverage as appropriate for this change.

m1aw avatar Oct 25 '18 12:10 m1aw

no possible side effects?

janpio avatar Oct 30 '18 12:10 janpio

As far as we could test, no there are no side effects, so we decided to use it in production. I'm not an expert though, so maybe someone else can take a look at it.

m1aw avatar Nov 08 '18 18:11 m1aw

CI, please rerun tests.

janpio avatar Jul 04 '19 11:07 janpio

Android tests are not happy:

1) cordova-plugin-device-tests.tests >> Device Information (window.device) should contain a UUID specification that is a string or a number
  - Expected undefined to be defined.
  - Expected false to be true.

janpio avatar Jul 04 '19 12:07 janpio