cordova-plugin-dialogs icon indicating copy to clipboard operation
cordova-plugin-dialogs copied to clipboard

[MAJOR] GH-28 Progress dialogs should not be cancellable outside the window

Open brody4hire opened this issue 7 years ago • 5 comments

Proposal to cherry-pick the fix proposed in PR #28 without the whitespace fixes that are now part of PR #109. The change in behavior makes sense to me. I think this change should go into a new major release.

Resolves #28

brody4hire avatar Oct 04 '18 00:10 brody4hire

Please update the PR to describe what the codee change actually does, or what the situation before was.

janpio avatar Oct 04 '18 10:10 janpio

Pretty sure the change results in the dialogs not being cancellable by touching outside the dialog.

The problem, as I understand it, is that you can tap anywhere on the screen and thus cancel the dialog, which is almost always unintended for a progress indicator. This change fixes that.

oliversalzburg avatar Oct 04 '18 20:10 oliversalzburg

So the PR title is still wrong, correct @oliversalzburg?

janpio avatar Oct 30 '18 12:10 janpio

@janpio It is unless my interpretation of the change is wrong.

oliversalzburg avatar Oct 30 '18 12:10 oliversalzburg

I just corrected the title, thanks @oliversalzburg.

brody4hire avatar Oct 30 '18 13:10 brody4hire