cordova-plugin-device icon indicating copy to clipboard operation
cordova-plugin-device copied to clipboard

Published 20 hours ago • verified publisher icon apache

fix(android): access Context through webView.getContext() (CB-12623)

Open dreifachstein opened this issue 8 years ago • 7 comments
trafficstars

Android WebView can be created without an Activity. One use case is to create a WebView within a Service and attach/detach it to an Activity window on demand.

dreifachstein avatar Apr 23 '17 09:04 dreifachstein

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

66 tests run, 0 skipped, 0 failed.

cordova-qa avatar Apr 23 '17 09:04 cordova-qa

The CordovaWebView object is not actually an Android WebView, so this shouldn't be done.

infil00p avatar Apr 23 '17 22:04 infil00p

@infil00p should we close this?

filmaj avatar Apr 25 '17 00:04 filmaj

@filmaj Not sure. I'm not sure what the reporter is trying to do here.

infil00p avatar May 01 '17 17:05 infil00p

@dreifachstein, could you elaborate please?

janpio avatar Aug 10 '18 19:08 janpio

Looks good to me, but you'll have to update engines in package.json and plugin.xml to require cordova-android >= 7.0.0 as this is not available in older versions https://github.com/apache/cordova-android/commit/17906735dfe23e74cbe75394a0de3bf448233f25

And we on next plugin update should do a major bump because of the engines update

jcesarmobile avatar Aug 22 '18 10:08 jcesarmobile

Let there be tests.

janpio avatar Jul 04 '19 10:07 janpio

I didn't see the engine requirement cordova-android >= 7.0.0 being added as requested. Will we add it after this PR is merged?

erisu avatar May 14 '24 02:05 erisu

yeah, we can add it in a separate PR

jcesarmobile avatar May 14 '24 07:05 jcesarmobile