apache
(iOS) Add support for device name on iOS
Platforms affected
Motivation and Context
Progresses #130
Description
Testing
Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with
(platform)if this change only applies to one platform (e.g.(android)) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
- [ ] I've updated the documentation if necessary
Can you fill out the PR description, following the template?
And if it is to close a ticket also link the ticket. For example: Closes #<ticket number>
Also when I glanced the code, why are you stripping out the non-alphanumeric?
What happens if the device name is in another language such as Japanese, Chinese, etc?
Sorry, first time contributing to a Cordova repo.
- I only tested the changes locally, didn't run specific automated tests (not sure what testing environment/workflow you usually use.)
- prefixed the commit with platform.
- not related to an existing issue
- didn't update the documentation
Please let me know how to proceed, G
On Apr 9, 2022, at 10:35 PM, エリス @.***> wrote:
Can you fill out the PR description, following the template?
And if it is to close a ticket also link the ticket. For example: Closes #
Also when I glanced the code, why are you stripping out the non-alphanumeric?
What happens if the device name is in another language such as Japanese, Chinese, etc?
— Reply to this email directly, view it on GitHub https://github.com/apache/cordova-plugin-device/pull/168#issuecomment-1094184071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADIM3V46FSPDCKQ2ARWF2LVEJSA5ANCNFSM5TADQZVQ. You are receiving this because you authored the thread.
Going to close since starting on iOS 16 this is considered a sensitive piece of information and doesn’t return the value anymore unless you request a special entitlement to Apple, so the addition has limited usefulness for most users
https://developer.apple.com/documentation/uikit/uidevice/1620015-name
