cordova-plugin-contacts icon indicating copy to clipboard operation
cordova-plugin-contacts copied to clipboard
verified publisher icon apache

(ios) fixes background thread problem in pickContact method

Open lukas2 opened this issue 4 years ago • 8 comments

This fixes #228

lukas2 avatar Feb 26 '21 13:02 lukas2

Can we have the new version with this fix?

Sampath-Lokuge avatar Feb 27 '21 19:02 Sampath-Lokuge

Can we have the new version with this fix?

Before we can merge or make a release, the plugin needs to have it's testing tools updated. The tests are failing because it's still using versions that are no longer supported. To get this PR merged, I'd also like at least one other PMC member to vote green.

For the record, I don't believe anything in this change is causing the test to fail, just travis and appveyor configs needs to be updated. I have some time, I'll make those changes now. Once the test changes are merged in, I'll restart the checks here, and if they turn green I'll start nudging people to take a look.

breautek avatar Feb 28 '21 10:02 breautek

@breautek Ok sure. Thanks!

Sampath-Lokuge avatar Feb 28 '21 11:02 Sampath-Lokuge

Actually there won't be any releases (and I'll probably won't convince anybody else for a green check) as this plugin is deprecated. My apologies, I didn't realise this plugin was deprecated initially.

See https://github.com/apache/cordova-plugin-contacts#deprecation-notice and https://cordova.apache.org/news/2017/11/27/Deprecation-of-cordova-contacts-plugin.html for more details.

I personally don't know of any migration strategy or alternate solution, feel free to use your own fork of this plugin.

breautek avatar Feb 28 '21 14:02 breautek

@breautek Yes, I have manually applied this fix https://github.com/apache/cordova-plugin-contacts/pull/229/commits/868cfba60d2328306e3bb13bf98643c08c501622 on this plugin and it works. I use 2.3.1 Thanks!

Sampath-Lokuge avatar Feb 28 '21 14:02 Sampath-Lokuge

@breautek Yes, I have manually applied this fix 868cfba on this plugin and it works. I use 2.3.1 Thanks!

Hi, I'm experiencing this issue as well. How do I apply the fix to my project? Thanks.

zimejin avatar Mar 11 '21 13:03 zimejin

@zimejin You need to add this fix https://github.com/apache/cordova-plugin-contacts/pull/229/commits/868cfba60d2328306e3bb13bf98643c08c501622 to here src/ios/CDVContacts.m

Sampath-Lokuge avatar Mar 11 '21 13:03 Sampath-Lokuge

@Sampath-Lokuge Thanks for the quick response. I'll give this a try.

Regards

zimejin avatar Mar 11 '21 14:03 zimejin

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.

timbru31 avatar Jan 09 '23 07:01 timbru31