cordova-plugin-camera
cordova-plugin-camera copied to clipboard
(android) catch RecoverableSecurityException
Platforms affected
Android
Motivation and Context
https://github.com/apache/cordova-plugin-camera/issues/679 https://github.com/apache/cordova-plugin-camera/issues/660 https://github.com/apache/cordova-plugin-camera/issues/656 Closes #679 Closes #660 Closes #679
Description
Catch the RecoverableSecurityException and Requests permission to delete the media from the media store. see https://developer.android.com/training/data-storage/shared/media#update-other-apps-files
Testing
Using a Ulefone Armor 8, Android 10, api 29
Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with
(platform)
if this change only applies to one platform (e.g.(android)
) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
- [x] I've updated the documentation if necessary
Relaunching tests
The android test failures are due to a known incompatibility issue between cordova-android and cordova-paramedic testing tools. It's not the result of this PR, so they can probably be ignored for now.
Some point next week I am planning on updating one of my apps that uses the camera plugin, so I'll have an opportunity to test this PR at the same time.
@dongourdet @erisu @breautek Any new on this, we have some people having app crashes because this is not merged yet
Hi
We tested the fork on android devices that consistently gave problems (crashing when taking a pic) and it resolved it. We are currently pointing to that fork but would like to point to the source again before it gets stale.
Are there any updates on why this is not merged yet?
Could someone please provide the reasons for the non-acceptance of this pull request? It has been almost two years since it was submitted... @breautek @erisu