cordova-plugin-camera icon indicating copy to clipboard operation
cordova-plugin-camera copied to clipboard

Published 20 hours ago • verified publisher icon apache

CB-13307: (Android) Fixed issue when unable to load image with mime t…

Open DavidBriglio opened this issue 7 years ago • 6 comments

…ype "image/*", and failing to recognize new contentprovider uri authority.

Platforms affected

Android

What does this PR do?

Allows for image mimetype "image/*" to be accepted as a valid image. Allows for google photos uri authority ".contentprovider" to be recognized.

What testing has been done on this change?

When running "npm test" results in "invalid config loglevel='notice'". When running "npm run test-build" results in "missing script: test-build". Manual testing has been done on Android 8.0 Google Pixel with cordova cli 6.5.0.

DavidBriglio avatar Sep 21 '17 13:09 DavidBriglio

I'm cool with it, but I can't even test if this fixes it because I don't even have the ability to pull from Google Photos when I test it. Did that break on Android P?

infil00p avatar Mar 19 '18 20:03 infil00p

I have not done any testing on Android P, and do not have access to it.

DavidBriglio avatar Mar 20 '18 14:03 DavidBriglio

Hey @DavidBriglio , there seems to be a merge conflict now. Could you maybe fix this? Thanks.

janpio avatar Sep 16 '18 17:09 janpio

And another rebase/merge from master to get those tests passing @DavidBriglio?

janpio avatar Oct 01 '18 17:10 janpio

@janpio Tests are now passing!

DavidBriglio avatar Oct 01 '18 18:10 DavidBriglio

Jippieh! I removed some unwanted changes to README that somehow made their way into this via merge/rebase. Now "only" waiting for review and merge.

janpio avatar Oct 01 '18 19:10 janpio