cordova-node-xcode
cordova-node-xcode copied to clipboard
Cleanup
From review of PR #56 (watch2 support), I have a feeling that we should be able to clean up both the source code and all of the tests. I am raising this for future consideration and discussion.
Starting to add a list:
- [ ] use const & let instead of var, especially in new code (noticed after merging PR #56)
- [ ] look for ways to make the code easier to read & understand, especially the code added in PRs #56 & #76
/cc @l3ender
Regarding code readability, are you thinking to enhance dependency lookup ability, or a more general thought? If the former, I have a few thoughts based on work in https://github.com/apache/cordova-node-xcode/pull/76:
- Xcode links dependencies sort of messily, but helper functions could be exposed to help with this.
- The
addTarget
function could/should expose easier data about any generated dependencies it adds viaaddTargetDependency
(the new UUIDs generated fromaddTargetDependency
aren't in turn exposed through the response object ofaddTarget
).
I was thinking more general, dependency lookup ideas sound good.
Sent from my mobile