cordova-ios
cordova-ios copied to clipboard
fix: Set CodeSigning Entitlements in Xcode Project at Target level
Platforms affected
iOS
Motivation and Context
Closes GH-1135.
Description
Moved CODE_SIGN_ENTITLEMENTS from the xcconfig (which affects the entire project and all its targets) to the target settings of the application target within the Xcode project.
Testing
Confirmed manually that the Xcode project settings for the target have the expected values.
Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.35%. Comparing base (
2240ebc) to head (1cb893a).
Additional details and impacted files
@@ Coverage Diff @@
## master #1438 +/- ##
=======================================
Coverage 78.35% 78.35%
=======================================
Files 16 16
Lines 1825 1825
=======================================
Hits 1430 1430
Misses 395 395
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
hi Cordova team, very important issue, waiting!