cordova-ios icon indicating copy to clipboard operation
cordova-ios copied to clipboard

feat: support extending export options

Open dertieran opened this issue 4 years ago • 2 comments

Motivation and Context

Support extending the exportOptions through the buildOpts.

Resolves #1209

Checklist

  • [x] I've run the tests to see all new and existing tests pass
  • [x] I added automated test coverage as appropriate for this change
  • [x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [ ] I've updated the documentation if necessary

dertieran avatar Dec 07 '21 11:12 dertieran

Code wise everything looks good.

Can you provide me your example build command on how you tested it. How you set a single or multiple export options.

This information needs to be added later to the Cordova docs so others understand how to use it.

erisu avatar Mar 15 '22 07:03 erisu

Not quite sure if this is what you mean, but I'm not using cordova through the cli. So I didn't provide a way to set the exportOptions through the cli, but I guess it could be added as an option to the build.json.

I tested it through my build script that looks something like this

const build = async function ({ release, platforms }) {
    const exportOptions = { uploadSymbols: !release };
    const options = { release, device: release, exportOptions };
    await cordova.build({ verbose: !release, platforms, options });
};

build({ release: true, platforms: ['ios'] });

This will then not include the .symbols in the produced .ipa file. This command should not print anything in that case (by default it does).

unzip -l platforms/ios/build/device/<app>.ipa | grep Symbols

Also as mentioned in the issue, right now the code does not allow to overwrite the defaults. Not sure if that would be a good idea or if it would break the whole build. 😅

I hope this helps, let me know if I can help with anything else.

dertieran avatar Mar 15 '22 08:03 dertieran