cordova-electron icon indicating copy to clipboard operation
cordova-electron copied to clipboard

refactor: use node internal modules & replace fs-extra with node:fs

Open erisu opened this issue 11 months ago • 1 comments

Platforms affected

n/a

Motivation and Context

Modernaize code

Description

  • Use Node Internal Modules node:*
  • Replace fs-extra with node:fs
  • Improve PackageJsonParser testing

Testing

  • npm t

Checklist

  • [x] I've run the tests to see all new and existing tests pass
  • [x] I added automated test coverage as appropriate for this change
  • [ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [ ] I've updated the documentation if necessary

erisu avatar Mar 26 '24 05:03 erisu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d5ad929) to head (12335e1).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          656       659    +3     
=========================================
+ Hits           656       659    +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 26 '24 05:03 codecov-commenter