cordova-electron icon indicating copy to clipboard operation
cordova-electron copied to clipboard

Unable to set the custom icons

Open Polm90 opened this issue 2 years ago • 1 comments

Bug Report

Problem

What is expected to happen?

I want to customize the app icon, avoiding to use the default electron one.

What does actually happen?

Building the app, it says "default Electron icon is used reason=application icon is not set" and it uses the default icons and not the ones I've specified in config.xml file.

Information

Command or Code

Config.xml file:

 <platform name="electron">
    <preference name="ElectronSettingsFilePath" value="res/electron/settings.json"/>
    <preference name="ShowSplashScreen" value="true"/>
    <icon src="res/electron/icons/512x512.png" target="app"/>
    <icon src="res/electron/icons/1024x1024.png" target="installer"/>
  </platform>

Command: cordova build electron Note: using cordova run electron --nobuild works, but it's not what i want :)

Build.json:

{
  "electron": {
    "release": {
      "windows": {
        "package": [
          "msi",
          "appx"
        ],
        "arch": [
          "x64"
        ],
        "signing": {
          "release": {
            "certificateFile": "",
            "certificatePassword": ""
          }
        }
      }
    },
    "debug": {
      "windows": {
        "package": [
          "msi","zip"
        ],
        "arch": [
          "x64"
        ],
        "signing": {
          "release": {
            "certificateFile": "",
            "certificatePassword": ""
          }
        }
      }
    }
  }
}

Environment, Platform, Device, Version information

I'm on windows 11. Cordova: 11.1.0 Cordova-electron: 3.1.0

Checklist

  • [x] I searched for existing GitHub issues
  • [x] I updated all Cordova tooling to most recent version
  • [x] I included all the necessary information above

Polm90 avatar Feb 21 '23 11:02 Polm90

This issue still persists 15 Months later. Any help with this would be appreciated.

mbreslein-thd avatar May 28 '24 08:05 mbreslein-thd